Merged
Conversation
Move transmissibility calculation logic (TransmissibilityData, connection factor computation, non-Darcy flow calculations) from RicWellPathExportCompletionDataFeatureImpl into a dedicated RicTransmissibilityCalculator class. Add unit tests for the extracted calculator.
For dual porosity models, the first N K-layers represent MATRIX and K-layers N+1 to 2N represent FRACTURE. Shift K to the fracture section at production points so exported completion data (COMPDAT, WPIMULT, COMPLUMP, COMPSEGS) references the correct K-layer. Subtract the offset in LGR bounding box computation where original grid K is needed.
Improves the handling and display of dual porosity results by: - Adds an option to display a dual porosity label in the UI tree, clarifying the porosity model being used. - Adjusts the K index calculation for the fracture porosity model in relative permeability plots, ensuring correct indexing. - Adds a warning message when plotting relative permeability curves for fracture cells since it is not fully supported. - Replaces direct checks for dual-porosity results with checks against the main grid to determine dual porosity for UI element display.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13626